Kadanza DAM media connector v0.0.1 #81
Conversation
ivaylo-kostov-kad
commented
Nov 14, 2024
ivaylo-kostov-kad
commented
- Add a connector with query, detail, filtering, metadata capabilities
- Add support only for oAuth2ResourceOwnerPassword auth at this stage
* Add a connector with query, detail, filtering, metadata capabilities * Add support only for oAuth2ResourceOwnerPassword auth at this stage
ivaylo-kostov-kad
requested review from
brapoprod,
alexandraFlavia9,
psamusev,
pietervp,
Matthiee and
Dvergar
as code owners
|
@ivaylo-kostov-kad Would you be able to provide |
* Describe publish, runtime options and authentication
@psamusev - done. Kept it simple at this stage and we'll update it later once more auth and other options are added. |
|
@ivaylo-kostov-kad despite on the fact that using oAuthAuthorizationCode is not possible in a way how you would like to have it for Studio UI integration, can you still add support of this authorization type as well as example of how to configure it, to be able for example use this approach when you work with a connector via Platform => Studio Workspace integration? |
* Set author to Kadanza * Add icon url * Add oAuth2AuthorizationCode to supportedAuth * Set studio-connectors and connector-cli deps versions to the ones that were used while building and testing * Add oAuth2AuthorizationCode example in the readme
* Fix formatting * Remove name from auth example, no longer used
| // TODO -> handle medium/highres with conversion profiles? | ||
|
|
||
| case 'fullres': | ||
| case 'highres': |
There was a problem hiding this comment.
these types seems like didn't return any image or in a wrong format. At least for 'highres' it should image type as for thumbnail and mediums (although can be with higher resolution)
There was a problem hiding this comment.
@psamusev could you please add more details and specifics on the assets you tested with ? Additionally, what's an image in a wrong format?
Generally speaking, the current implementation returns the original asset and that does not guarantee that it will always be an image (this is expected as the DAM supports non-image file types as well).
There was a problem hiding this comment.
@ivaylo-kostov-kad you can find supported formats under "Supported Formats" section https://docs.chiligrafx.com/GraFx-Developers/connectors/media-connector/media-connector-fundamentals/#download-method. In addition this PR can be used as a reference chili-publish/studio-sdk#371
In short, we're working only with JPEG, PNG or PDF (for 'fullres' and 'original') only
There was a problem hiding this comment.
@psamusev OK, thanks - that's clear. We don't expect GraFx to support other formats. Our expectation is that if an asset download is requested and the original is a non-supported format, loading (or rendering) the asset in the document will fail - that's fine for us.
That's why you also see a TODO on line 197 - we will eventually decide whether we need to add custom logic for other formats when we actually start using the connector in real-life use-cases.
