Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocked][Feature] Add sitecore connector #77

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

michvh-dev
Copy link

@michvh-dev michvh-dev commented Oct 22, 2024

This is the Sitecore connector created by Digital Herd

@brapoprod brapoprod changed the title add sitecore connector [Feature] Add sitecore connector Oct 23, 2024
Copy link
Member

@brapoprod brapoprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested

src/connectors/sitecore/readme.md Show resolved Hide resolved
src/connectors/sitecore/connector.ts Outdated Show resolved Hide resolved
src/connectors/sitecore/package-lock.json Outdated Show resolved Hide resolved
src/connectors/sitecore/package.json Outdated Show resolved Hide resolved
"relationMetadataIncludes": ""
},
"supportedAuth": [
"oAuth2ResourceOwnerPassword",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified an internal issue on the serverside for supporting your resource-owner flow. We are going to follow this up with high priority and will let you know when it's ready. The issue causes the server to not be able to authenticate properly and thus causes issues in output and preview generation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brapoprod So, there’s nothing we can do about this, right? Or do we need to implement a workaround?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michvh-dev No indeed, we follow up on our end to fix this issue asap.

src/connectors/sitecore/readme.md Outdated Show resolved Hide resolved
src/connectors/sitecore/readme.md Outdated Show resolved Hide resolved
src/connectors/sitecore/readme.md Outdated Show resolved Hide resolved
brapoprod
brapoprod previously approved these changes Oct 25, 2024
@brapoprod brapoprod changed the title [Feature] Add sitecore connector [Blocked][Feature] Add sitecore connector Oct 25, 2024
@brapoprod
Copy link
Member

We'll keep this open until our fix has been provided

src/connectors/sitecore/readme.md Outdated Show resolved Hide resolved
src/connectors/sitecore/package.json Show resolved Hide resolved
@psamusev
Copy link
Collaborator

psamusev commented Nov 6, 2024

@michvh-dev can u please fetch the latest updates from main of original repo that includes #78. Currently it's not possible to build your connector

* main:
  CI: bumps version to @chili-publish/connector-cli v1.9.1
  [Fix][WRS-2106] Add support of "authorizationServerMetadata" to OAuth2ResourceOwner (chili-publish#78)
@michvh-dev
Copy link
Author

@psamusev this is now done, sorry didn't see that the Pull Request was merged

@psamusev
Copy link
Collaborator

@michvh-dev May I ask you to sync with main again. We found another issue in CLI that was fixed in context of #79

* main:
  CI: bumps version to @chili-publish/connector-cli v1.9.2
  [Fix] Make "bodyFormat" as optional in OAuth2ResourceOwner authentication configuration (chili-publish#79)
@michvh-dev
Copy link
Author

@psamusev done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants