-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date range to data.json #98
Conversation
✅ Deploy Preview for creative-quokka-61f1f5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for sprightly-muffin-751ffc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR will adversely impact the changes I am working on for Issue #66 which are being worked upon in branch Decouple-data-part-1. In fact, it may actually be easier to decouple the data first and then implement this change. No matter how we do this, the changes will need to be coordinated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filename name is a PITA. It will be difficult to type with both _ and - in the name. It also is visually tough to decipher. Perhaps it should be renamed something like, data-20220520-20230702. json
I wonder if it might be easier to add some kind of date labeling within |
In light of Laurie's comments, I've realized putting the date in the file name itself will force us to update the code every time the file is update with a new date range. This is the opposite of our end goal to decouple the data from the code. As it stands now, I would have to vote against this solution. The date range must be in the file data itself. It can either be on each record or a different element within the data structure. [date1, date2, routedata] |
Thanks for the comments. I'll remove the date from the filename and add another field to |
This reverts commit 2e98458.
Is there an associated backend update which needs to be merged before this PR is merged? How is the date information being populated in the data.json file? |
There are still unanswered questions about this change.
There isn't a backend update yet, but I'm not sure it would affect this PR. |
This feature got added elsewhere |
Description
Checklist
Screenshots
Fixes #97