Make the onbootsec parameter to attribute

[vineethp088]

This is to make the OnBootSec parameter to control via attribute when the chef-client runs as a timer service,

Description

This is to make the OnBootSec parameter to control via attribute when the chef-client runs as a timer service.
There are cases chef-client run after the boot is elapsed, becuase of the default 1min and there should be a mechanism to control this parameter.
Changing this parameter to hgher value seems to be fixing this and should be control it via attribute, keeping 1 min as default.

Issues Resolved

There are cases chef-client run after the boot is elapsed, becuase of the default 1min and there should be a mechanism to control this parameter.
Changing this parameter to higher value seems to be fixing this and should be control it via attribute, keeping 1 min as default.

Check List

• All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
• New functionality includes testing.
• New functionality has been documented in the README if applicable
• All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

[tas50]

This resource is actually a backport from Chef Infra Client 16 so we need to keep the default value the same as it is in client at 1min.

[vineethp088]

We wanted to make the OnBootsec parameter as attribute, so that it can be controlled. We are seeing a problem with the chef client timer its getting elapased ( when runinng the chef client as a timer). We do not see that problem all the time/servers but we could reproduce the elapsed issue after reducing/increasing the onbootsec parameter. So if it can be controlled by node attribute it will help us fixing this issue. We can keep the default as ( 1 min/60sec) , May be I didnt get the point here about the chef16 dependecny.

[phiggins]

This cookbook has a systemd resource copied from Chef Infra 16, so that users of the cookbook can use older versions of Chef Infra. In order to ease transitioning to use the resource in Chef Infra 16, this needs to be defined the same as the one there: https://github.com/chef/chef/blob/master/lib/chef/resource/chef_client_systemd_timer.rb#L65-L67

The other changes in this PR are fine, but changing the default from '1min' to '60sec' needs to be reverted.

[vineethp088]

Sure, Reverted let me know if this is fine. We just need that attribute to be controlled.

[vineethp088]

Please let me know if this can be merged or need any additional modification ?

[dheerajd-msys]

@vineethp088 Please check #707 (comment)

[dheerajd-msys]

Issue #627 probably be fixed by this PR

[phiggins]

I think this change is a good idea, but I don't think this is the right way to do it and this is complicated by what looks like a bug from confusing behavior.

• The properties delay_after_boot, interval, and splay are eventually used as systemd time spans.
• delay_after_boot and interval accept arbitrary strings, so they can be a number of seconds eg '60' or it can include time units eg 5h30m.
• splay is coerced to an integer so it is assumed to be a number of seconds.

Appending sec onto the value specified for delay_after_boot in recipes/systemd_service.rb could end up with incorrect values like '5h30msec. That also means the current behavior of interpolating interval is incorrect. Since bare values are interpreted as seconds, the code in the recipe should probably use the values directly:

      'OnBootSec' => node['chef_client']['delay_after_boot'],
      'OnUnitInactiveSec' => node['chef_client']['interval'],
      'RandomizedDelaySec' => node['chef_client']['splay'],

[dheerajd-msys]

@vineethp088 Could you please make changes per suggestion here ? then I guess we would be good to merge the PR.

Thanks