feat(teatest/v2): use virtual terminal #250
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caarlos0 Could you split the changes into 2 PRs? It's hard to look at when for are in the same one 😄 |
yes, will do once its stable 🙏🏻 |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
caarlos0
changed the title
Signed-off-by: Carlos Alexandro Becker <[email protected]>
|
Could you rebase this onto |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
i'm using vt@vt, it seems to have race conditions again 🤔 |
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Co-authored-by: Ayman Bagabas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes x/exp/teatest/v2 to use x/vt as its input/output.
This is effectively a breaking change, which should be ok as teatest is still experimental.
.Output()will now return a text representation of the current output, instead of what was written since the last call to it.FinalOutput()is pretty waits for the program to exit and then calls.Output()IMHO this is good, let me know what you think!