fix getting null id for some versions of rack #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzjfr
force-pushed
the
master
branch
3 times, most recently
from
a198c49
to
6a38e0e
Compare
lusinh
reviewed
Dec 21, 2020
| @@ -149,13 +149,13 @@ def session_hash | |||
| # # request.session_options[:id].encode("ISO-8859-1") | |||
| if Rails::VERSION::MAJOR >= 4 | |||
| session["init"] = true | |||
| id = session.id.to_s | |||
| id = session.id.public_id.to_s | |||
There was a problem hiding this comment.
@rzjfr
If session.id is null, It will raise exception here. You should check null value for session.id
There was a problem hiding this comment.
correct, title is misleading
There was a problem hiding this comment.
Thanks digging into this @rzjfr. I think something like this might work for any rack version >= 2.1.0
def session_hash
id = session.id || request.session_options[:id]
if id.respond_to?(:cookie_value)
id.cookie_value
elsif id.is_a?(Rack::Session::SessionId)
id.public_id
end
end
invalidusrname
changed the title
|
I noticed we have a couple of PRs related to method. I'm going to close this one out in favor of #298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with rake version that do not have rack/rack#1462 will have problem getting
session.id.to_safter GHSA-hrqr-hxpp-chr3I'd say having
public_idis much safer, it should not break any version.I also bumped into this issue #292 which might be fixed with this change.