Dyno: fix promotion infinite recursion due to type returning functions

[DanilaFe]

On main, because we allowed promotion to be applied to functions with the type and param intents, it was possible to trigger recursive queries, in which chpl_promotionType would be applied in a promoted manner. As a concrete example, the following test by @riftEmber caused an infinite recursion error:

use OS;
var x = createSystemError(0);

This PR ensures that this no longer happens, by matching the production compiler's behavior and skipping type-returning procedures:

chapel/compiler/resolution/functionResolution.cpp

Lines 1783 to 1788 in df1f0f4

	if (fn != NULL &&
	fn->name != astrSassign &&
	strcmp(fn->name, "these") != 0 &&
	fn->retTag != RET_TYPE &&
	fn->retTag != RET_PARAM &&
	actualType->scalarPromotionType != NULL &&

Thank you @riftEmber for diagnosing the issue and reviewing the PR!

Testing

• dyno tests, including regression test

[riftEmber]

lgtm! thanks for the fix