Fix cryptic "failed to exec /usr/bin/env" errors with gasnet launchers #26281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: jabraham17 <[email protected]>
Signed-off-by: jabraham17 <[email protected]>
jabraham17
changed the title
jhh67
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a cryptic error that can occur when there are enough environment variables that are long, causing us to run out of space in a buffer. This is especially a problem for something like spack, which is prone to embedding very long paths in many environment variables.
This PR works around this by excluding certain environment variables we know aren't needed, in this case the PR excludes all variables suffixed with
_modshare. These variables end up being duplicateted, so you haveVAR="some long string"andVAR_modshare="some long string". Its not important we maintain the duplicates, so this PR just filters them out.Tested that with this patch the error goes away
[Reviewed by @jhh67]