Print printchplenv
warnings at the end of the output
#26272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes how
printchplenv
prints warnings so that the warnings are outputed last.Prior to this PR,
printchplenv
warnings could get lost if the terminal scrolled past. This PR puts the warnings last so that users can be more directly notified. The exception is in the error case. If there was an error and printchplenv is going to exit, all to the warnings are printed before the errors, so that users can see warnings that may have lead to the error being produced.Note: if a user throws
--ignore-errors
, no warning buffering is done, otherwiseprintchplenv
may crash without dumping the buffer out.Testing:
CHPL_LLVM_VERSION=2 printchplenv --all
shows the warning at the bottomCHPL_DEVELOPER=1 CHPL_TARGET_COMPILER=gnu CHPL_TARGET_CC=clang CHPL_LLVM_VERSION=2 printchplenv --all
shows the warning and then the exceptionCHPL_DEVELOPER=0 CHPL_TARGET_COMPILER=gnu CHPL_TARGET_CC=clang CHPL_LLVM_VERSION=2 printchplenv --all
shows the warning and then prints the errorCHPL_TARGET_COMPILER=gnu CHPL_TARGET_CC=clang CHPL_LLVM_VERSION=2 printchplenv --all --ignore-errors
does no buffering[Reviewed by @vasslitvinov]