Rename some uses of "parenth" to "paren" in language server and compiler #26256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etc. I at first thought this was a typo for "parent", but Jade said it was short for parentheses. If my memory serves, we typically shorten that to `paren` instead, so rename the method and its uses to reflect that. A `make test-chpl-language-server` behaved the same as on nightly ---- Signed-off-by: Lydia Duncan <[email protected]>
lydia-duncan
added
stat: Needs Code Review
area: Python bindings
DanilaFe
reviewed
Nov 19, 2024
Does not include the generated parser changes, I'm putting that in a separate commit for cleanliness ---- Signed-off-by: Lydia Duncan <[email protected]>
---- Signed-off-by: Lydia Duncan <[email protected]>
It looks like they were unnecessary anyways, but that's kinda annoying ---- Signed-off-by: Lydia Duncan <[email protected]>
lydia-duncan
changed the title
parenth_location to paren_location in the language server/etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I at first thought this was a typo for "parent", but Jade said it was short for parentheses. If my memory serves, we typically shorten that to
pareninstead, so rename the methods and their uses to reflect that.A
make test-chpl-language-serverbehaved the same as on nightly. A full paratest only turned up failures that looked related to the system updates we've been doing and I could verify all but one of them worked okay in other locations (the last one being gdb specific and thus not testable on my mac)