Resolve basic associative domains with module code in Dyno #26077
+150
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
dyno-associative-domains
branch
2 times, most recently
from
a365a3f
to
8070e30
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
7 times, most recently
from
cadb922
to
87170da
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
11 times, most recently
from
fad38de
to
f45eb4b
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
- Return true from resolveFnCallSpecial if handled - Invert result for != Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
dyno-associative-domains
branch
from
62eab18
to
262abef
Compare
riftEmber
changed the title
riftEmber
changed the title
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get associative domains resolving using their module code in Dyno, and re-enable testing.
This PR itself contains little work and mostly just drove Dyno work needed to support the module code.
Completes part of https://github.com/Cray/chapel-private/issues/6729.
Also includes:
helpResolveFunctionto run on generic type constructors, per bug fix suggestion from Benparam == ?comparisons which was introduced in Dyno: Improve initialization of fields from non-matching types #26219, so that it gets specially handled rather than trying to resolve a defined==operator[reviewer info placeholder]
Testing: