Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate extra typings for number token identifiers #2951

Closed

Conversation

thecodrr
Copy link

Closes #2950

📝 Description

This PR adds support for generating extra typings for number token identifiers.

⛳️ Current behavior (updates)

Currently, Panda converts number identifiers to strings causing type errors when strictTokens is enabled.

🚀 New behavior

Described above.

💣 Is this a breaking change (Yes/No):

No. The number types are just added in addition to string types so this change won't break any existing Panda usage but would greatly enhance the experience for future users. Users can optionally switch to using numbers in their styles anytime they want.

📝 Additional Information

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: e1a4e8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@pandacss/shared Patch
@pandacss/dev Patch
@pandacss/config Patch
@pandacss/core Patch
@pandacss/extractor Patch
@pandacss/generator Patch
@pandacss/node Patch
@pandacss/parser Patch
@pandacss/studio Patch
@pandacss/token-dictionary Patch
@pandacss/types Patch
@pandacss/astro-plugin-studio Patch
@pandacss/postcss Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-base Patch
@pandacss/preset-open-props Patch
@pandacss/preset-panda Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Oct 31, 2024 0:36am
panda-playground ✅ Ready (Inspect) Visit Preview Oct 31, 2024 0:36am
panda-studio ✅ Ready (Inspect) Visit Preview Oct 31, 2024 0:36am

@segunadebayo
Copy link
Member

Closing based on #2950 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number token identifiers get converted to string when strictTokens is turned on
2 participants