Generate extra typings for number token identifiers #2951
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2950
📝 Description
This PR adds support for generating extra typings for
number
token identifiers.⛳️ Current behavior (updates)
Currently, Panda converts
number
identifiers tostring
s causing type errors whenstrictTokens
is enabled.🚀 New behavior
Described above.
💣 Is this a breaking change (Yes/No):
No. The number types are just added in addition to string types so this change won't break any existing Panda usage but would greatly enhance the experience for future users. Users can optionally switch to using numbers in their styles anytime they want.
📝 Additional Information