Skip to content

Commit

Permalink
[tlul/rtl] Modify readback check error reporting logic
Browse files Browse the repository at this point in the history
Currently, only a readback error check is reported when the `error_i`
signal is not raised. However, as this signal is also raised when there
is no activity on the TL-UL bus, we might miss some readback failures.

This commit modifies the error reporting logic to also report the
readback mismatch when the error signal is raised.

Closes lowRISC#24698.

Signed-off-by: Pascal Nasahl <[email protected]>
  • Loading branch information
nasahlpa authored and vogelpi committed Sep 30, 2024
1 parent 6819083 commit 267e61c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions hw/ip/tlul/rtl/tlul_sram_byte.sv
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ module tlul_sram_byte import tlul_pkg::*; #(
rdback_wait = 1'b1;
rdback_check_d = MuBi4False;

// Perform the readback check. Omit the check if the transaction contains an error.
if (!rdback_chk_ok && !error_i) begin
// Perform the readback check.
if (!rdback_chk_ok) begin
alert_o = 1'b1;
end
end
Expand Down

0 comments on commit 267e61c

Please sign in to comment.