This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Support Enable/Disable NiFi Zookeeper client Zookeeper Ensemble Tracker #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is bumping NiFi to 1.20 also, nice, thanks! Unfortunately one of the tests fails: https://github.com/cetic/helm-nifi/blob/253ad43b273075bf91165f320bac3794a2446d4f/.github/workflows/test-site-to-site.yml |
banzo
added
enhancement
Signed-off-by: Tan Luu <[email protected]>
Signed-off-by: Tan Luu <[email protected]>
* Fix s2s test Signed-off-by: Tan Luu <[email protected]>
|
thank you, can you please update the PR title and description to reflect the change in NiFi version? This will help to autogenerate the release notes. Also I am curious what is the difference between the cert-manager.io and jetstack versions for cert-manager. |
nathluu
changed the title
|
Hi @banzo , |
When you point a web browser to https://github.com/jetstack/cert-manager it automatically redirects to https://github.com/cert-manager/cert-manager so I would recommend reverting to the cert-manager.io URL, as it seems to be the long-term supported reference to that project. |
wknickless
reviewed
May 16, 2023
| cmctl -n alpha renew nifi-0 | ||
| kubectl -n alpha rollout restart statefulset/nifi |
There was a problem hiding this comment.
This defeats the purpose of the test, which was to confirm that NiFi is automatically detecting the certificate has changed and restarting the TLS modules. If we want to disable this test because NiFi is broken, then I would recommend commenting it out with a comment rather than forcing a restart.
There was a problem hiding this comment.
Add a TODO to remove this block of code when NIFI issue is fixed
Signed-off-by: Tan Luu <[email protected]>
* Add session affinity FAQ --------- Co-authored-by: Chengjun Fu <[email protected]>
…etic#301) Signed-off-by: Michael Dent <[email protected]> Co-authored-by: Michael Dent <[email protected]>
* Update nifi.properties - Add values - nifi.security.user.oidc.preferred.jwsalgorithm={{.Values.auth.oidc.preferredJwsalgorithm}}
* Update values.yaml - Add auth.oidc.preferredJwsalgorithm value
* Update README.md - Add info about nifi.security.user.oidc.preferred.jwsalgorithm
Signed-off-by: joseph.ybh <[email protected]> Co-authored-by: joseph.ybh <[email protected]>
Signed-off-by: Tan Luu <[email protected]>
Signed-off-by: Tan Luu <[email protected]>
* Fix s2s test Signed-off-by: Tan Luu <[email protected]>
Signed-off-by: Tan Luu <[email protected]>
…m:nathluu/helm-nifi into nathluu/zkclient-ensemble-tracker-disable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From NiFi 1.20.0 it supports configuration to enable/disable Zookeeper(zk) client zk Ensemble Tracker as of NIFI-10481.
With zk ensemble tracker enabled (default by NiFi), nifi zk client resolves the zk connection string to IP addresses then when all zk server pods get restarted and come up with a different IP, NiFi pods cannot reconnect to zk.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]