-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brotli compression support #379
Conversation
@stefanv I need to make some changes to the GA (like go back to the real baselayer app template not my fork) before merging anything, but this works very well! The code snippet from the GA can be reused in the SkyPortal dockerfile to install nginx with brotli :). I will also add some documentation before merging, but re-requesting a review so you can see the new code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few small questions.
@stefanv updated the GA and the docs to install from the ppa, and updated the python logic to find the nginx brotli module. This is solid, works well on both dynamic and static installations (and on both windows and mac). Let me know what you think. If we want this to be tested, we will have to update the baselayer template app with a test (like the one I added to the fork pinned here for testing). So if you are happy with these changes, let me know and I'll pin the normal template app again and we can merge :) |
I like it! Let's also merge the test on BL. |
Great! I went back to git cloning the real template app in the GA. I'll open the PR on the template app ASAP. |
Don't review yet, just a draft