Make channel tokens be compatible with Centrifugo v4+ #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I have discovered that if rubycent version 3.0.0 is being used against Centrifugo server versions 4+ (tested with centrifugo server 4.1.5 and 5.4.6, and centrifuge v5.2.2 nodejs module) then channel tokens issued with the help of
client
parameter do not allow subscribing to channels. Debug log in centrifugo server in this case looks like this:After applying changes in this PR (so basically you just need to use
sub
instead ofclient
in payload sent toJWT.encode
, just like for connection tokens) I can successfully subscribe to channels:If everything is ok and I'm not missing anything, could you please review, merge the PR and release a new version to rubygems ?