Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deadlock when GetChannelMediumOptions is used #404

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Aug 1, 2024

When GetChannelMediumOptions is used addSubscription call acquired subLock mutex, HandlePublication tried to acquire the same mutex concurrently before addSubscription call released one. This resulted into deadlock.

Also, fixing behaviour of ping_pong_duration_seconds to not count clients which did not sent pong in time as this resulted in negative values.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (70fd357) to head (71cf2c3).

Files Patch % Lines
node.go 18.18% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   81.46%   81.25%   -0.21%     
==========================================
  Files          40       40              
  Lines        7174     7193      +19     
==========================================
+ Hits         5844     5845       +1     
- Misses        952      972      +20     
+ Partials      378      376       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FZambia FZambia merged commit 96afa72 into master Aug 1, 2024
8 checks passed
@FZambia FZambia deleted the fix_dealock branch August 1, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant