Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upnode gentx #440

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Add Upnode gentx #440

merged 6 commits into from
Oct 25, 2023

Conversation

upnodedev
Copy link
Contributor

Overview

Add Upnode gentx and peer

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@MSevey
Copy link
Member

MSevey commented Oct 24, 2023

please make sure your gentx is formatted. These lines are failing:

     "non_critical_extension_options":[
        
     ]

       "amount":[
           
        ],

there shouldn't be empty lines.
You can use jq to format

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signature verification failed; please verify account number (0), sequence (0) and chain-id (celestia): unauthorized

please make sure the correct chain-id was used

celestia/peers.txt Outdated Show resolved Hide resolved
@evan-forbes evan-forbes dismissed their stale review October 24, 2023 20:39

removing the additional block, but we still need to fix conflicts and CI before we merge

celestia/peers.txt Outdated Show resolved Hide resolved
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. sync your fork: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
  2. merge master into your branch patch-1
  3. move your peer into a separate file: under celestia, e.g. celestia/upnode.txt (as described here as well)
  4. make sure to not edit peers.txt (aka there should be no diff between peers.txt on master and in your branch)

Thank you

@liamsi liamsi enabled auto-merge (squash) October 25, 2023 09:26
auto-merge was automatically disabled October 25, 2023 09:44

Head branch was pushed to by a user without write access

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@evan-forbes evan-forbes merged commit d70cae9 into celestiaorg:master Oct 25, 2023
8 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 25, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants