Fix alarms with missing data #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staging: pinpoint_to_sqs_sms_callbacks✅ Terraform Init: Plan: 0 to add, 4 to change, 0 to destroyShow summary
Show planResource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_cloudwatch_metric_alarm.pinpoint-sms-success-rate-critical[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-critical" {
id = "pinpoint-sms-success-rate-critical"
tags = {}
# (15 unchanged attributes hidden)
- metric_query {
- id = "failures" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "pinpoint-sms-failures" -> null
- namespace = "LogMetrics" -> null
- period = 43200 -> null
- stat = "Sum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- id = "successes" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "pinpoint-sms-successes" -> null
- namespace = "LogMetrics" -> null
- period = 43200 -> null
- stat = "Sum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- expression = "successes / (successes + failures)" -> null
- id = "success_rate" -> null
- label = "Success Rate" -> null
- period = 0 -> null
- return_data = true -> null
}
+ metric_query {
+ id = "failures"
+ return_data = false
+ metric {
+ metric_name = "pinpoint-sms-failures"
+ namespace = "LogMetrics"
+ period = 43200
+ stat = "Sum"
}
}
+ metric_query {
+ id = "successes"
+ return_data = false
+ metric {
+ metric_name = "pinpoint-sms-successes"
+ namespace = "LogMetrics"
+ period = 43200
+ stat = "Sum"
}
}
+ metric_query {
+ expression = "successes / (successes + failures)"
+ id = "success_rate"
+ label = "Success Rate"
+ return_data = true
}
}
# aws_cloudwatch_metric_alarm.pinpoint-sms-success-rate-warning[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-warning" {
id = "pinpoint-sms-success-rate-warning"
tags = {}
# (15 unchanged attributes hidden)
- metric_query {
- id = "failures" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "pinpoint-sms-failures" -> null
- namespace = "LogMetrics" -> null
- period = 43200 -> null
- stat = "Sum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- id = "successes" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "pinpoint-sms-successes" -> null
- namespace = "LogMetrics" -> null
- period = 43200 -> null
- stat = "Sum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- expression = "successes / (successes + failures)" -> null
- id = "success_rate" -> null
- label = "Success Rate" -> null
- period = 0 -> null
- return_data = true -> null
}
+ metric_query {
+ id = "failures"
+ return_data = false
+ metric {
+ metric_name = "pinpoint-sms-failures"
+ namespace = "LogMetrics"
+ period = 43200
+ stat = "Sum"
}
}
+ metric_query {
+ id = "successes"
+ return_data = false
+ metric {
+ metric_name = "pinpoint-sms-successes"
+ namespace = "LogMetrics"
+ period = 43200
+ stat = "Sum"
}
}
+ metric_query {
+ expression = "successes / (successes + failures)"
+ id = "success_rate"
+ label = "Success Rate"
+ return_data = true
}
}
# aws_cloudwatch_metric_alarm.total-sms-spending-critical[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-critical" {
id = "total-sms-spending-critical"
tags = {}
# (15 unchanged attributes hidden)
- metric_query {
- id = "pinpoint_spend" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "TextMessageMonthlySpend" -> null
- namespace = "AWS/SMSVoice" -> null
- period = 300 -> null
- stat = "Maximum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- id = "sns_spend" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "SMSMonthToDateSpentUSD" -> null
- namespace = "AWS/SNS" -> null
- period = 300 -> null
- stat = "Maximum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- expression = "sns_spend + pinpoint_spend" -> null
- id = "total_spend" -> null
- label = "Total SMS Monthly Spend" -> null
- period = 0 -> null
- return_data = true -> null
}
+ metric_query {
+ id = "pinpoint_spend"
+ return_data = false
+ metric {
+ metric_name = "TextMessageMonthlySpend"
+ namespace = "AWS/SMSVoice"
+ period = 300
+ stat = "Maximum"
}
}
+ metric_query {
+ id = "sns_spend"
+ return_data = false
+ metric {
+ metric_name = "SMSMonthToDateSpentUSD"
+ namespace = "AWS/SNS"
+ period = 300
+ stat = "Maximum"
}
}
+ metric_query {
+ expression = "sns_spend + pinpoint_spend"
+ id = "total_spend"
+ label = "Total SMS Monthly Spend"
+ return_data = true
}
}
# aws_cloudwatch_metric_alarm.total-sms-spending-warning[0] will be updated in-place
~ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-warning" {
id = "total-sms-spending-warning"
tags = {}
# (15 unchanged attributes hidden)
- metric_query {
- id = "pinpoint_spend" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "TextMessageMonthlySpend" -> null
- namespace = "AWS/SMSVoice" -> null
- period = 300 -> null
- stat = "Maximum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- id = "sns_spend" -> null
- period = 0 -> null
- return_data = false -> null
- metric {
- dimensions = {} -> null
- metric_name = "SMSMonthToDateSpentUSD" -> null
- namespace = "AWS/SNS" -> null
- period = 300 -> null
- stat = "Maximum" -> null
- unit = "Count" -> null
}
}
- metric_query {
- expression = "sns_spend + pinpoint_spend" -> null
- id = "total_spend" -> null
- label = "Total SMS Monthly Spend" -> null
- period = 0 -> null
- return_data = true -> null
}
+ metric_query {
+ id = "pinpoint_spend"
+ return_data = false
+ metric {
+ metric_name = "TextMessageMonthlySpend"
+ namespace = "AWS/SMSVoice"
+ period = 300
+ stat = "Maximum"
}
}
+ metric_query {
+ id = "sns_spend"
+ return_data = false
+ metric {
+ metric_name = "SMSMonthToDateSpentUSD"
+ namespace = "AWS/SNS"
+ period = 300
+ stat = "Maximum"
}
}
+ metric_query {
+ expression = "sns_spend + pinpoint_spend"
+ id = "total_spend"
+ label = "Total SMS Monthly Spend"
+ return_data = true
}
}
Plan: 0 to add, 4 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Saved the plan to: plan.tfplan
To perform exactly these actions, run the following command to apply:
terraform apply "plan.tfplan"
Show Conftest resultsWARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.pinpoint_deliveries"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.pinpoint_deliveries_failures"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.pinpoint_to_sqs_sms_callbacks_log_group[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.lambda-image-pinpoint-delivery-receipts-errors-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.lambda-image-pinpoint-delivery-receipts-errors-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.logs-1-500-error-1-minute-warning-pinpoint_to_sqs_sms_callbacks-api[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.logs-10-500-error-5-minutes-critical-pinpoint_to_sqs_sms_callbacks-api[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.pinpoint-sms-blocked-as-spam-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.pinpoint-sms-phone-carrier-unavailable-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.pinpoint-sms-rate-exceeded-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.pinpoint-sms-success-rate-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.pinpoint-sms-success-rate-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.total-sms-spending-critical[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.total-sms-spending-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.pinpoint_logs"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.pinpoint_logs"]
35 tests, 19 passed, 16 warnings, 0 failures, 0 exceptions
|
|
Updating alarms ⏰? Great! Please update the Google Sheet and add a 👍 to this message after 🙏 |
ben851
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
The pinpoint-sms-success-rate-warning alarm doesn't have any data (see discussion here)
Looking at the alarm in Metrics and removing the
unitparameter caused the graph to have data. This is an optional field so I believe deleting it should be fine (especially if it fixes the metrics / alarms!)Also fixed the
total-sms-spending-*alarms - the Pinpoint spending was not appearing (AWS/SMSVoice). Removing theunits fixed these.Related Issues | Cartes liées
Didn't make one 😬
Test instructions | Instructions pour tester la modification
Check that data appears. Should have signifcant spending in
total-sms-spending-warning(with the Pinpoint now counted). Can view the alarm in metrics and plot all the metrics used in the calculations.Release Instructions | Instructions pour le déploiement
Other metrics might be affected similarly...
Reviewer checklist | Liste de vérification du réviseur