Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lc setup links #799

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Update lc setup links #799

merged 2 commits into from
Sep 15, 2023

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented May 21, 2023

No need to add setup.html for workbench

#798

No need to add setup.html for workbench
@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for workshop-template-previews ready!

Name Link
🔨 Latest commit 1e50ef6
🔍 Latest deploy log https://app.netlify.com/sites/workshop-template-previews/deploys/6504ce1edfae2f0008933007
😎 Deploy Preview https://deploy-preview-799--workshop-template-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bkmgit
Copy link
Contributor Author

bkmgit commented May 28, 2023

@tobyhodges Could you take a look at this? It is similar to your last change.

Copy link
Contributor

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have one minor suggestion to add the "#setup" tag so that it will direct learners to the setup section. It's not necessary, though as the sidebar will direct them as well.

_includes/lc/setup.html Outdated Show resolved Hide resolved
_includes/lc/setup.html Outdated Show resolved Hide resolved
@zkamvar
Copy link
Contributor

zkamvar commented Sep 15, 2023

I apologise for my lateness on getting back to this. I'm going to merge it and fix the other links as well.

@zkamvar zkamvar merged commit 876db81 into carpentries:gh-pages Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants