Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #546] add human language in workshop description #625

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

fmichonneau
Copy link
Contributor

@malvikasharan, @raynamharris, @rgaiacs what do you think of this implementation and text for #546.

TODO:

  • add this new variable to the customization page

@fmichonneau
Copy link
Contributor Author

@carpentries/lesson-infrastructure-committee do you have any suggestion about this proposed fix?

_config.yml Outdated
@@ -37,6 +37,9 @@ flavor: "r"
# https://github.com/carpentries/workshop-template#creating-extra-pages
title: "Workshop Title"

# If this variable is set to something else than `""`, the language in which the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## human_language: the language in which the workshop is taught.
# If set to anything other than "", a note about the language of the workshop is
# added to the workshop description.

index.md Outdated

{% unless site.human_language == "" %}
<p id="human-language">
<strong>The course will be conducted in {{ site.human_language }}.</strong> For this course, we will expect our participants to have basic understanding of {{ site.human_language }}. We will have several helpers to assist you if you need some terms to be translated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

course -> workshop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about We will have several helpers to assist you if you need some terms to be translated. Which terms do you mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I copied this from @malvikasharan and I understood it as any word that could have been difficult to understand. How about replacing "terms" with "words"?

Copy link
Contributor

@maxim-belkin maxim-belkin Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing "terms" with "words"?

it is better though it does not add clarity... I guess I don't understand the purpose of this sentence. I'd say something like this:

Helpers will be available if you need assistance with ... understanding lesson material. (???)

I'd also wrap the body of the paragraph.

<strong>The workshop will be conducted in {{ site.human_language }}.</strong>
For this course, we will expect our participants to have basic understanding
of {{ site.human_language }}. We will have several helpers to assist you if
you need assistance with understanding the lesson material.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "with" in the last line does not need to be here.

I do still find this somewhat confusing. Is the idea that the helpers will be fluent in both the workshop language and another language to help with translation?

Maybe there should be two fields in config (I don't love this proposal, but thinking together is better than alone):
workshop-human-language and local-human-language and then display the paragraph if those do not match (with appropriate update to the comment)? and in the reference to helpers can note that the helpers will be competent in both workshop and local languages? @malvikasharan @raynamharris would that be helpful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think that the intent was that helpers would be proficient both language and could help with translation if needed. That sentence I took from @malvikasharan's workshop might be too specific to be generalizable to all workshops, and it might be best to leave it out?

@@ -37,6 +37,10 @@ flavor: "r"
# https://github.com/carpentries/workshop-template#creating-extra-pages
title: "Workshop Title"

## human_language: the language in which the workshop is taught.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest listing couple of examples after this first line, e.g. "English", "Dutch", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants