-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin versions of sandpaper, pegboard, and varnish #7
Conversation
Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/intro-to-modern-fortran/compare/md-outputs..md-outputs-PR-7 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-02-20 21:16:44 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've chased the documentation and code through several repositories, and still haven't found what uses these keys, but it looks similar to what some other carpentries repositories do, and is thus probably fine.
You'll want to be careful about testing before pushing to main in these forks, as they will be directly used here.
Auto-generated via {sandpaper} Source : d48e7d4 Branch : main Author : Dimitrios Theodorakis <[email protected]> Time : 2024-02-26 18:38:29 +0000 Message : Pin versions of sandpaper, pegboard, and varnish (#7) * Pin versions of sandpaper, pegboard, and varnish Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Auto-generated via {sandpaper} Source : 9ff76a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-26 19:05:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d48e7d4 Branch : main Author : Dimitrios Theodorakis <[email protected]> Time : 2024-02-26 18:38:29 +0000 Message : Pin versions of sandpaper, pegboard, and varnish (#7) * Pin versions of sandpaper, pegboard, and varnish Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Auto-generated via {sandpaper} Source : 9ff76a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-26 19:05:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d48e7d4 Branch : main Author : Dimitrios Theodorakis <[email protected]> Time : 2024-02-26 18:38:29 +0000 Message : Pin versions of sandpaper, pegboard, and varnish (#7) * Pin versions of sandpaper, pegboard, and varnish Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Auto-generated via {sandpaper} Source : 9ff76a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-26 19:05:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d48e7d4 Branch : main Author : Dimitrios Theodorakis <[email protected]> Time : 2024-02-26 18:38:29 +0000 Message : Pin versions of sandpaper, pegboard, and varnish (#7) * Pin versions of sandpaper, pegboard, and varnish Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Auto-generated via {sandpaper} Source : 9ff76a1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-26 19:05:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d48e7d4 Branch : main Author : Dimitrios Theodorakis <[email protected]> Time : 2024-02-26 18:38:29 +0000 Message : Pin versions of sandpaper, pegboard, and varnish (#7) * Pin versions of sandpaper, pegboard, and varnish Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
Pinning these dependencies to my versions of these packages so we can user Mermaid, sphinx like tabs, and the Dark mode.
I think this will work! It does locally but I guess the real test is whether the GitHub pages deployment is happy with the pinned versions.
Links to the separate pull requests for more info:
Add support for tabs / tabset panels carpentries/sandpaper#571
Add support for tabs / tabset panels carpentries/pegboard#148
Add support for tabs / tabset panels carpentries/varnish#121
Implement dark mode carpentries/varnish#124
Incorporate mermaid diagrams carpentries/varnish#125