-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed pagination label for select #18166
base: main
Are you sure you want to change the base?
fix: changed pagination label for select #18166
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18166 +/- ##
=======================================
Coverage 83.36% 83.36%
=======================================
Files 404 404
Lines 14344 14344
Branches 4646 4646
=======================================
Hits 11958 11958
+ Misses 2225 2224 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SR's announcements are more clear now. It reads "5, page of 11 pages" !! Thanks
Closes #17974
Change label of select to
Page
instead ofPage Number
Testing / Reviewing
page 1 of 11 pages
when focus is on select menu for page number.