Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed aira-current in breadcrumb #18155

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 25, 2024

Closes #18113

Added the aria-current to the span tag that it is generated in the DOM

Testing / Reviewing

  • Open Breadcrumb With Overflow Menu stories and turn on the VO.
  • You should hear "Breadcrumb 6, current item"

Screenshot 2024-11-25 at 14 10 15

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 72281b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6744afce3fb7aa0008461878
😎 Deploy Preview https://deploy-preview-18155--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 72281b2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6744afcde76f190008e7a293
😎 Deploy Preview https://deploy-preview-18155--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 72281b2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6744afcd4ae26d0008abe96f
😎 Deploy Preview https://deploy-preview-18155--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (626289a) to head (72281b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...react/src/components/Breadcrumb/BreadcrumbItem.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18155      +/-   ##
==========================================
+ Coverage   82.87%   83.22%   +0.34%     
==========================================
  Files         404      404              
  Lines       14338    14339       +1     
  Branches     4591     4592       +1     
==========================================
+ Hits        11882    11933      +51     
+ Misses       2296     2245      -51     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Breadcrumbs don't inform screen reader about current page
1 participant