fix(MenuItemSelectable): remove duplicate onChange #17967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17967 +/- ##
==========================================
+ Coverage 81.80% 81.82% +0.02%
==========================================
Files 404 404
Lines 14088 14086 -2
Branches 4409 4379 -30
==========================================
+ Hits 11524 11526 +2
+ Misses 2401 2397 -4
Partials 163 163 ☔ View full report in Codecov by Sentry. |
This is the same issue and fix that was previously addressed for `MenuItemRadioGroup` in carbon-design-system#17736. Also added a test to cover this case, including checking the value passed to the `onChange` prop as the redundant `onChange` being removed here was passing the SyntheticEvent instead of the expected boolean.
AlanGreene
force-pushed
the
menuitemselectable_duplicate_onChange
branch
from
e6f8f77
to
2f8173e
Compare
guidari
approved these changes
Nov 5, 2024
2nikhiltom
approved these changes
Nov 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hi folks, is there anything else needed to get this merged? Looks like all checks are passing. |
Looks like it's good to go! Added to the merge queue |
Merged
via the queue into
carbon-design-system:main
with commit Nov 11, 2024
664408d
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17968
This is the same issue and fix that was previously addressed for
MenuItemRadioGroupin #17736.Also added a test to cover this case, including checking the value passed to the
onChangeprop as the redundantonChangebeing removed here was passing the SyntheticEvent instead of the expected boolean.Changelog
Changed
onChangeis only called onceTesting / Reviewing
Unit test added to cover the expected behaviour.