fix: popover is clipping in modal #17840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17840 +/- ##
==========================================
- Coverage 80.16% 80.14% -0.03%
==========================================
Files 406 406
Lines 14029 14029
Branches 4343 4363 +20
==========================================
- Hits 11246 11243 -3
- Misses 2617 2619 +2
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
kennylam
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
kennylam
approved these changes
Oct 23, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 23, 2024
abde1a4
39 of 40 checks passed
|
Hey there! v11.69.0 was just released that references this issue/PR. |
irfadkp
pushed a commit
to irfadkp/carbon
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17749
popover was clipping in modal
Changelog
Changed
The issue was caused by the drop-shadow, as it creates a stacking effect. So I applied the drop-shadow to its direct child .#
{$prefix}--popover-contentinstead of.#{$prefix}--popoverTesting / Reviewing