Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): remove presentational checkmark svg from accessibility tree #17719

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Oct 10, 2024

Closes #17676

Reference

Changelog

Changed

  • add aria-hidden and focusable:false to checkmark svg

Testing / Reviewing

  1. Open Toggle component description on storybook
  2. Go to playground and choose the "sm" value of "size" prop
  3. Open the result in fullscreen/iframe
  4. Scan it with IBM Equal Access Accessibility Checker
  5. There should be no violation regarding the svg having no accessible name

@tay1orjones tay1orjones requested a review from a team as a code owner October 10, 2024 19:57
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 51d4e62
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67093e3b70d2cd000824bc47
😎 Deploy Preview https://deploy-preview-17719--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 51d4e62
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67093e3b5ca14a0008f2313b
😎 Deploy Preview https://deploy-preview-17719--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (261d33c) to head (51d4e62).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17719   +/-   ##
=======================================
  Coverage   79.00%   79.00%           
=======================================
  Files         408      408           
  Lines       14008    14008           
  Branches     4319     4367   +48     
=======================================
  Hits        11067    11067           
  Misses       2775     2775           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Oct 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 11, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Oct 14, 2024
Merged via the queue into carbon-design-system:main with commit 797fe0f Oct 14, 2024
23 checks passed
@tay1orjones tay1orjones deleted the 17676-toggle-fix branch October 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Small toggle triggers "The SVG element has no accessible name"
4 participants