Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarqube.yml #991

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

juanmarin97
Copy link
Contributor

@juanmarin97 juanmarin97 commented Oct 3, 2023

Change the environment variables to access to external database and not use the H2 internal Tier

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

Change the environment variables to access to external database and not use the H2 internal Tier
@githubsaturn
Copy link
Collaborator

Thanks for the PR! Can you please confirm that this is tested.

@juanmarin97 juanmarin97 marked this pull request as draft October 4, 2023 15:27
- Setup the last version of sonarqube
- Add ports
@juanmarin97 juanmarin97 marked this pull request as ready for review October 6, 2023 06:45
@juanmarin97
Copy link
Contributor Author

Thanks for the PR! Can you please confirm that this is tested.

Hi @githubsaturn tested on a productive env.

@uhlhosting
Copy link

@githubsaturn any updates?

@githubsaturn
Copy link
Collaborator

The build is failing. Feel free to update the PR and resubmit.

@juanmarin97
Copy link
Contributor Author

This is working fine
image
image

@githubsaturn githubsaturn merged commit 3b0223b into caprover:master Jan 4, 2024
1 check passed
@githubsaturn
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants