Securise app version and upgrade validate_app #1171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
Hi,
I tried to standardize the
$$cap_app_name
to check and to fix all the fixed versions without variables and with fixed values.I added three checks on validate app :
I also use a
for of
instead of thevar i
for performance purpose.To finish I would later create a new command to know which packages are deprecated and from how long
I think this PR is more readable commit by commit.
I hope this could help
Regards
npm ci && npm run validate_apps && npm run formatter
(If failling run the prettier:npm run formatter-write
)