Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Plausible}change to smtp image from bytemark/smtp to navanchauhan/smtp to include image with arm support #1156

Closed
wants to merge 1 commit into from

Conversation

abhranil26
Copy link
Contributor

Also updated default version of plausible to the latest version.

I have tested this, it works!

First of all, thank you for your contribution! 😄

Please note that this repo is mostly for popular apps with thousands of stars and tens of thousands of downloads. If you'd like to add a less popular app, you can always create your own 3rd party repo and add your app there.

☑️ Self Check before Merge

  • I have tested the template using the method described in README.md thoroughly
  • I have ensured that I put as much default values as possible (except passwords) to ensure minimum effort required for end users to get started.
  • I have ensured that I am not using the "latest" tag as this tag is dynamically changing and might break the one-click app. Use a fixed version.
  • I have made sure that instructions.start and instructions.end are clear and self-explanatory.
  • Icon is added as a png file to the logos directory.
  • I've executed the checks if necessary by running npm ci && npm run validate_apps && npm run formatter (If failling run the prettier: npm run formatter-write)
  • I will take responsibility addressing any issues that arises as a result of this PR (maintaining this app).

@abhranil26 abhranil26 changed the title change to smtp image from bytemark/smtp to navanchauhan/smtp to include image with arm support {Plausible}change to smtp image from bytemark/smtp to navanchauhan/smtp to include image with arm support Oct 11, 2024
@githubsaturn
Copy link
Collaborator

Thanks for the PR, but this image is very random image and we won't include it in the official repository due to high risk.

The official image is much safer - even though it may not have the capabilities of the other image.

@abhranil26
Copy link
Contributor Author

abhranil26 commented Oct 12, 2024

Hmm after checking i found that Plausible have since integrated a new email client built in in the new versions. Separate smtp not required. Just need to set MAILER_ADAPTER=Bamboo.Mua in env variables.
Tested and it works.
Gonna update the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants