Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding websocket support from one click templates #132

Conversation

IzzleNizzle
Copy link
Contributor

I created an app with the one-click-app database recently and websocket support was not checked by default. This caused the app to not work appropriately until that was enabled. I posted in slack about this and was encouraged to submit a pull request. Please let me know if any adjustments need to be made.

What I've done here is enabled the front end to pass on a property from a one-click-template for the websocketSupport variable.

This will enable one click app templates to automatically have websocket support checked if they so wish. They can just add a property like the following:

services:
    $$cap_appname:
        ...

        caproverExtra:
            websocketSupport: 'true'

        ...

I tested to ensure this was not a breaking change, and was an opt in only type of feature. From my testing this is friendly to templates with or without the variable.

@githubsaturn githubsaturn merged commit 1b3211f into caprover:master Oct 4, 2023
3 checks passed
@githubsaturn
Copy link
Collaborator

Nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants