Snapcraft: Improved LXD Snap Completions #14506
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kadinsayani
force-pushed
the
completer-script
branch
from
d47639f
to
01b7da6
Compare
kadinsayani
force-pushed
the
completer-script
branch
from
01b7da6
to
83ff572
Compare
This commit adds `snap_completer.sh`, which provides improved bash completions for the LXD snap. Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
completer-script
branch
from
83ff572
to
99a0230
Compare
There was a problem hiding this comment.
As annoying/agonizing as it is, I think we could still get away with keeping the snapcraft build time inline patching if we add the following (albeit ugly) bit:
lxc completion bash | sed ... -e 's|$(type -t compopt)|"builtin"|' ...
I've put up canonical/lxd-pkg-snap#630 to that effect, still untested though.
I’ll give this a try tomorrow. If both approaches work, it’s just a matter of preference. I like using the modified script in this PR because it has comments about my findings throughout the debugging process with the hope that future issues will be easier to resolve. Also, it puts us in the driver seat rather than relying on Cobra's generated completion script. |
Thanks for putting this up :) |
|
Closing in favour of canonical/lxd-pkg-snap#630. Thanks @simondeziel 😄 |
Fixes the extraneous space issue raised in #14264.
This PR adds
snap_completer.sh, which provides improved bash completions for the LXD snap. Rather than generating the completion script during the LXD Snapoverride-buildstep and stream editing the file to work withsnapdcompletions, including a modified script is more reliable. Moving forward, completions for the LXC CLI can be added/changed directly inlxc/completion.gowith a guarantee that Cobra completion directives (such asShellCompDirectiveNoSpaceandShellCompDirectiveNoFileComp) will get along withsnapd.For reference, here is the associated PR for
lxd-pkg-snap.