Notifier update; MemberState update #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
MggMuggins
force-pushed
the
notifier-update
branch
from
7bdc6b7
to
dfffaf5
Compare
|
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
MggMuggins
force-pushed
the
notifier-update
branch
2 times, most recently
from
8f382c5
to
da0b159
Compare
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
tomponline
reviewed
Oct 18, 2024
|
cluster tests are sad |
6 tasks
Unfortunately the notifier is called during database startup before the global config has been loaded, so we need to fall back on loading the offline threshold from the database. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Avoid a query when a caller already has NodeInfo. This also makes possible using NotifyAll for a subset of cluster members. Signed-off-by: Wesley Hershberger <[email protected]>
This allows a hook to get some basic info about the cluster member that it's reaching out to without needing to make an explicit `GetServer` call. Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
notifier-update
branch
from
da0b159
to
0cb54f6
Compare
Signed-off-by: Wesley Hershberger <[email protected]>
This correctly initializes the config so that we can grab cluster.offline_threshold from it during the notify tests. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
No longer requires making an http request to the target member to get its name. Signed-off-by: Wesley Hershberger <[email protected]>
No longer require making an http request to the target member to get its name. I also removed the GetServer during storage pool deletion; it's unclear to me what the purpose of this extra request was; it was introduced in fe0d87f but that commit doesn't provide any context. I'll restore the request if I run into storage-related CI failures. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
memberName implies that this function will work for any cluster member, not just the local one Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
The instance options docs (doc/reference/instance_options.md) play a little fast and loose with terminology: for integer values of limits.cpu it only refers to "CPU(s)" without specifying vCPU, thread or core. LogicalCPUs from the golang std NumCPU is probably the best fit here. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
This is currently unused but will be utilized for resource reservations Signed-off-by: Wesley Hershberger <[email protected]>
And set the test state's server name when clustered Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
This will allow avoiding a GET /1.0/cluster/members/{name}/state when
validating resource reservations, and may be useful for validating
future config keys.
Signed-off-by: Wesley Hershberger <[email protected]>
config.Dump() creates and passes back a new map, so there's no need to do it a second time. Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
MggMuggins
force-pushed
the
notifier-update
branch
from
0cb54f6
to
a608e3b
Compare
tomponline
approved these changes
Oct 21, 2024
MggMuggins
added a commit
to MggMuggins/lxd
that referenced
this pull request
Oct 21, 2024
Covers changes introduced with canonical#14294 Signed-off-by: Wesley Hershberger <[email protected]>
hamistao
pushed a commit
to hamistao/lxd
that referenced
this pull request
Oct 25, 2024
Covers changes introduced with canonical#14294 Signed-off-by: Wesley Hershberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes preparatory changes as described in #14247:
state.ServerClusteredOfflineThresholdunless needed (see commit msg)db.NodeInfotoNewNotifierdb.NodeInfoto the notifier hook to reduce the need for extra http calls for basic info (like the target server's name)CPUThreadstoClusterMemberSysInfo(name tbd)MemberStateto expose localClusterMemberSysinfoPerformance improvements for project limits will be in a separate PR.