Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): add retry properties to generated templates #1142

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

chillleader
Copy link
Member

Description

Adds retry properties to the template generator.

Related issues

related to #1007

@chillleader chillleader self-assigned this Sep 14, 2023
@chillleader chillleader marked this pull request as ready for review September 14, 2023 21:15
@chillleader chillleader requested a review from a team as a code owner September 14, 2023 21:15
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chillleader chillleader marked this pull request as draft September 18, 2023 15:47
@chillleader
Copy link
Member Author

Converting to draft until clarifying the blockers (see parent issue)

@chillleader chillleader force-pushed the 1007-retry-properties-in-generator branch from 7250d76 to 752bed2 Compare September 20, 2023 07:28
@chillleader chillleader marked this pull request as ready for review September 20, 2023 07:28
@chillleader
Copy link
Member Author

As agreed, removed the retry count property and made the retry backoff property hidden.

@chillleader chillleader force-pushed the 1007-retry-properties-in-generator branch from 752bed2 to 40e4d77 Compare September 20, 2023 07:33
@chillleader chillleader merged commit 48d50fb into main Sep 20, 2023
1 check passed
@chillleader chillleader deleted the 1007-retry-properties-in-generator branch September 20, 2023 15:03
@sbuettner sbuettner added this to the 8.3 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants