Improved router #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polytypic
force-pushed
the
feature/improved-router
branch
13 times, most recently
from
24ee766
to
ab03180
Compare
polytypic
force-pushed
the
feature/improved-router
branch
3 times, most recently
from
3559003
to
35dea54
Compare
polytypic
force-pushed
the
feature/improved-router
branch
3 times, most recently
from
cbbc06c
to
859fab4
Compare
polytypic
force-pushed
the
feature/improved-router
branch
from
859fab4
to
e37e0f7
Compare
polytypic
force-pushed
the
feature/improved-router
branch
3 times, most recently
from
ba204ac
to
de6df57
Compare
|
When this improvement is finished do you think it could be made into it's own library? With the recent addition of XHR and the clean up of Util I feel like a router is about the only thing missing from making the Karet / Calmm toolkit feel complete. |
|
Hopefully soon, because there is a project where I'd like to able to it, but, as usual, free time is finite. :) |
polytypic
force-pushed
the
feature/improved-router
branch
3 times, most recently
from
36ac2ef
to
f940baf
Compare
polytypic
force-pushed
the
feature/improved-router
branch
3 times, most recently
from
59fb545
to
0815665
Compare
WIP: The idea is to make it so that parameters are transmitted as atoms and the component function is only called when the route changes. If only parameters change, then the changes are propagated via the observables as usual.
polytypic
force-pushed
the
feature/improved-router
branch
from
0815665
to
1e15f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: The idea is to make it so that parameters are transmitted as observables
and the component function is only called when the route changes. If only
parameters change, then the changes are propagated via the observables as usual.