-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api-docs): handle the default value of parameter correctly #333
Conversation
/cherrypick release-0.2 |
@iawia002: once the present PR merges, I will cherry-pick it on top of release-0.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
All comments addressed, PTAL @hezhizhen |
/lgtm |
What? Setting an empty default value for those non-basic types? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hezhizhen, iawia002 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@iawia002: new pull request created: #334 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
For now, if we set a default value for a field of an auto parameter, the API docs generation will fail with the error below:
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #272
Special notes for your reviewer:
/cc @hezhizhen @supereagle
Release note: