feat: instrument traceroute check #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Treml <[email protected]>
lvlcn-t
added
feature
lvlcn-t
requested review from
y-eight,
niklastreml,
puffitos and
eumel8
as code owners
y-eight
reviewed
Sep 11, 2024
Signed-off-by: Bruno Bressi <[email protected]>
puffitos
reviewed
Sep 11, 2024
* refactor: use checkname as trace name * refactor: use explicit default case * fix: set error statuses for errors * refactor: function naming * feat: add more span attributes
This was referenced Sep 13, 2024
Closed
puffitos
reviewed
Sep 17, 2024
* chore: rm named returns * chore: mark no route to host error as error * chore: rename hop method to doHop Signed-off-by: lvlcn-t <[email protected]>
Signed-off-by: lvlcn-t <[email protected]>
niklastreml
approved these changes
Oct 7, 2024
y-eight
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partly addresses #111 but could also be extended to the other checks and parts of the sparrow to provide technical information about the sparrow.
Changes
I've instrumented the traceroute check to provide more information about how the traceroute performed. The traceroute check now starts a span for each target to trace the route to. In this span each hop then starts a new span to provide information about the hop. The spans are then sent to the configured telemetry backend.
For additional information look at the commits.
Tests done
Unit tests succeeded- Not applicable for this PRManual e2e tests
Here is how the traces will then look like in Jaeger:
And this is how a trace then looks like:
TODO