fix: set true always #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Treml <[email protected]>
Signed-off-by: Niklas Treml <[email protected]>
lvlcn-t
approved these changes
Oct 15, 2024
puffitos
reviewed
Oct 15, 2024
|
Crossplane expects the function pipeline to set it afaik. There is an "auto-ready" function, which tries to find the composed resources' readiness automatically. Tried it, doesn't work for us, since it looks for a status: ready object on the composed resource, which the logging does not have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #3
This essentially forces the readiness to be true