Upkeep

[olivroy]

Adds the linewidth aes to keep up with ggplot2 3.4.0 closes #232
Remove tidyverse, tidyselect dependencies
Fix tests (the S&P 600 link didn't work at first
Remove outdated docs/ directory. (no longer needed since pkgdown is deployed with gh pages)
Move API dependencies to Suggests Close #211
Fix the package alias issue
Remove library() calls to avoid namespace problems.
Change FB -> META in FANG + in all docs. close #233
Regenerate FANG by saving it as csv. then data-raw with mutate(FB =FANG)
Update pkgdown config + rename logo file to logo so that pkgdown recognizes it properly.
Since tidyverse 2.0 is now exporting lubridate. You may consider moving lubridate from depends to imports and not load it with tidyquant.

Cheers

This silences CRAN warnings + notes. R CMD CHECK passes on windows.

[mdancho84]

Thanks a lot for your help!!

I'm running some checks now.

If I don't get back to this immediately ping me. I'm working on a pytimetk which is taking my focus. So if I don't respond ping me.

[olivroy]

Many of the failures in the vignette is due to errors reading data from online. I fixed the docs issue + the vignette name. It passes with no errors locally for me now.

[mdancho84]

I just ran again.

[olivroy]

It seems that there are no CI failures now.

[mdancho84]

Nice work. I'm wondering though about the FB -> META change. Just because there is probably code out there that uses FANG and filters on FB. If I get a bunch of people complaining then I may have to revert back. And we can make an new dataset MANG.

[olivroy]

But I think this could be a "correct" breaking change, since it makes the examples using FANG now more consistent with tq_get()
Probably better to have the next release as 1.1.0 or 2.0.

What do you think about not loading lubridate with tidyquant? (I could open a follow-up PR)

Also, if you could provide guidance for #235, I think it would be very great. These warnings are a bit annoying. :) I may look into it too if you don't have time.

[mdancho84]

True. Let's see what happens. Could make a legacy FANG. And a NEW FANG. AKA MANG. Or something that includes NVDA now since it's the new darling in tech.

P.S. Let me know if you want to help out with any of the other issues. Or if you want to do some software dev on other R projects and Python projects.

[olivroy]

Also, #230 can be closed.

But I was wondering if you would consider deprecating the mutate_xy_*() methods and like tidyverse, only support one set: NSE? I would work on that. But I think this would make the package easier to maintain and cleaner.

I also think it would be worthwhile closing old issues than can't be reproduced anymore or not valid.

P.S. Let me know if you want to help out with any of the other issues. Or if you want to do some software dev on other R projects and Python projects.

I am interested!

[mdancho84]

I agree 100%.

This is what I'm working on now: pytimetk: https://business-science.github.io/pytimetk/