Adding Dotfuscator #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikuB
reviewed
Jun 19, 2019
| <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" /> | ||
| <PropertyGroup> | ||
| <DotfuscatorXamarinConfigFileName>DotfuscatorConfig.xml</DotfuscatorXamarinConfigFileName> | ||
| <DotfuscatorXamarinCliPath>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\Extensions\PreEmptiveSolutions\DotfuscatorCE\dotfuscatorCLI.exe</DotfuscatorXamarinCliPath> |
There was a problem hiding this comment.
so assumption here is the person getting this project must have the enterprise version of VS 2019 installed at this path?
There was a problem hiding this comment.
That's a good question and I wasn't sure how to solve this. At the moment, yes, the expectation is that if you don't have the dotfuscator installed it won't work
There was a problem hiding this comment.
ok guess will have to see if there's a way to do it differently (note: i know the guide references the absolute path like you have)
There was a problem hiding this comment.
Three lines up it uses $(MSBuildExtensionsPath) in the Import element. Can we see if that works when specifying the DotfuscatorXamarinCliPath?
MaikuB
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.