-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted files and updated geochart chart window code #418
base: horizon
Are you sure you want to change the base?
Conversation
…to horizon getting up to date
…nto horizon fixing merge conflict
Thanks for cleaning up this PR! It made it much easier to understand what was going on for me, I really appreciate it. When I run this example:
I get an apparent “infinite loop”, though what's really happening is one of two errors inside the chart library, either:
Or:
Relatedly, when I run the example using @blerner and I think there may be some kind of race condition between rendering the chart and getting its image data. Have you run into this as well/any ideas? @sorawee any insights from your experience? |
Also, when I do get the image, it doesn't use the red color in the docs (https://github.com/brownplt/pyret-docs/pull/64/files), I get: Have you seen any inconsistencies in how the images render in different browsers, etc? |
No description provided.