Add code to new repo #1
Conversation
There was a problem hiding this comment.
#Required Changes ♻️
Hello bronnie313,
thanks for the effort that you've so far put in however there are some changes that you need to give attention to so that you wrap up this amazing project
Check the comments under the review.
submit your project when done and re-request a code review
thank you😃
|
|
||
| body { | ||
| background-color: rgb(231, 240, 240); | ||
| } | ||
|
|
||
| #main{ | ||
| text-align: center; | ||
| } |
There was a problem hiding this comment.
I think it would be better if you complete the CSS part because it's incomplete work. please finish applying styles to every part of your HTML classes where necessary to make your work look pleasant.
| <header> | ||
| <h1 id="title">Dr. Norman Borlaug</h1> |
There was a problem hiding this comment.
Your page is currently not semantically compliant. Implement the following to help improve HTML semantics i.e correct use of HTML elements.
- I think it would be better if this section use a header tag for only the header part and a class header but not for the whole body as you've done
Dr. Norman Borlaug
There was a problem hiding this comment.
Hi @bronnie313,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- Good use of Github flow ✔️
- Comments are polite and provide a reason ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
created a new repository
added HTML and CSS code from my previous project of the admissions trial.