PROD-1000 Increase default boot disk from 10gb to 20gb for GCP (#7585)

broadinstitute · Nov 20, 2024 · cae0a01 · cae0a01
1 parent 61a89e3
commit cae0a01
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -54,7 +54,9 @@ The `IX_WORKFLOW_STORE_ENTRY_WS` index is removed from `WORKFLOW_STORE_ENTRY`.
 
 The index had low cardinality and workflow pickup is faster without it. Migration time depends on workflow store size, but should be very fast for most installations. Terminal workflows are removed from the workflow store, so only running workflows contribute to the cost.
 
-### Bug fixes
+### Bug fixes and small changes
+
+ * Changed default boot disk size from 10GB to 20GB in PipelinesAPI and Google Batch backends
 
 #### Improved `size()` function performance on arrays
 

diff --git a/centaur/src/main/resources/standardTestCases/docker_size_dockerhub.test b/centaur/src/main/resources/standardTestCases/docker_size_dockerhub.test
@@ -11,8 +11,8 @@ files {
 
 metadata {
   status: Succeeded
-  "outputs.docker_size_dockerhub.large_dockerhub_image_with_hash.bootDiskSize": 17
-  "outputs.docker_size_dockerhub.large_dockerhub_image_with_tag.bootDiskSize": 17
+  "outputs.docker_size_dockerhub.large_dockerhub_image_with_hash.bootDiskSize": 27
+  "outputs.docker_size_dockerhub.large_dockerhub_image_with_tag.bootDiskSize": 27
 }
 
 workflowType: WDL
diff --git a/centaur/src/main/resources/standardTestCases/docker_size_gcr.test b/centaur/src/main/resources/standardTestCases/docker_size_gcr.test
@@ -11,8 +11,8 @@ files {
 
 metadata {
   status: Succeeded
-  "outputs.docker_size_gcr.large_gcr_image_with_hash.bootDiskSize": 17
-  "outputs.docker_size_gcr.large_gcr_image_with_tag.bootDiskSize": 17
+  "outputs.docker_size_gcr.large_gcr_image_with_hash.bootDiskSize": 27
+  "outputs.docker_size_gcr.large_gcr_image_with_tag.bootDiskSize": 27
 }
 
 workflowType: WDL
diff --git a/...batch/src/main/scala/cromwell/backend/google/batch/models/GcpBatchRuntimeAttributes.scala b/...batch/src/main/scala/cromwell/backend/google/batch/models/GcpBatchRuntimeAttributes.scala
@@ -63,7 +63,7 @@ object GcpBatchRuntimeAttributes {
 
   val BootDiskSizeKey = "bootDiskSizeGb"
   private val bootDiskValidationInstance = new IntRuntimeAttributesValidation(BootDiskSizeKey)
-  private val BootDiskDefaultValue = WomInteger(10)
+  private val BootDiskDefaultValue = WomInteger(20)
 
   val NoAddressKey = "noAddress"
   private val noAddressValidationInstance = new BooleanRuntimeAttributesValidation(NoAddressKey)

diff --git a/...c/main/scala/cromwell/backend/google/pipelines/common/PipelinesApiRuntimeAttributes.scala b/...c/main/scala/cromwell/backend/google/pipelines/common/PipelinesApiRuntimeAttributes.scala
@@ -67,7 +67,7 @@ object PipelinesApiRuntimeAttributes {
 
   val BootDiskSizeKey = "bootDiskSizeGb"
   private val bootDiskValidationInstance = new IntRuntimeAttributesValidation(BootDiskSizeKey)
-  private val BootDiskDefaultValue = WomInteger(10)
+  private val BootDiskDefaultValue = WomInteger(20)
 
   val NoAddressKey = "noAddress"
   private val noAddressValidationInstance = new BooleanRuntimeAttributesValidation(NoAddressKey)