Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vam: Fix summarize where #5503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vam: Fix summarize where #5503

wants to merge 1 commit into from

Conversation

mattnibs
Copy link
Collaborator

Fix issue with incorrect counts when using where clauses on a aggregation function in vector runtime. If a value fails the where clause make the value as null so it is skipped by the aggregation function.

Closes #5468

@mattnibs mattnibs requested a review from a team November 25, 2024 19:08
Fix issue with incorrect counts when using where clauses on a
aggregation function in vector runtime. If a value fails the where
clause make the value as null so it is skipped by the aggregation
function.

Closes #5468
}
vector.SetNulls(vec, nulls)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying a vector that might be shared (as I think vec is since it arrived here via args) is unsafe since other branches of the flowgraph (and thus other goroutines) may also have a reference to it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good point no sure what to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector query with "where" clause returns incorrect count
2 participants