Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits to super command doc #5487

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Minor edits to super command doc #5487

merged 1 commit into from
Nov 18, 2024

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Nov 17, 2024

These are some minor changes that come to mind while I was reviewing #5481.

This only touches the first half of the doc and not the second half with the Performance section. I've been writing some scripts to make it easy to run those queries and assemble the results so we can revisit them frequently and also point users at a way to run them easily on an AWS instance as neutral turf. I'll put up a separate PR next with those changes.

@philrz philrz self-assigned this Nov 17, 2024
Comment on lines +64 to +66
and both are equivalent to the classic SQL
```
super -c "SELECT typeof(this) FROM example.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting the feel for when and how much to reassure readers that standard SQL is still in there. I know we've talked about covering this topic in more detail when we get to overhauling the Language docs. Regardless, my instincts are to make some nods to classic SQL early in individual docs pages since we can't always be sure where users will first land and we can't be confident they'll always click on links when we hope they will. While we hope that users will quickly catch on to SuperSQL's pipe extensions so they can do things with super-structured data that classic SQL can't, I also want to make it as clear as possible to the new users that learning new elements are not a prerequisite to getting started, hence my addition of this new text.

Also related to this is when to use ALL CAPS. Once again, it feels worthwhile to use all caps in contexts where we're showing pure SQL that could drop directly into some other classic relational system. Likewise if we're showing an example that learns mostly/exclusively on SuperSQL shortcuts it seems reasonable to opt for lowercase, even if the example shares a few keywords common in classic SQL. Then there seems to be a gray area when it's a mix. On the whole though, my instincts are to start from all caps when possible to maximize approachability to the SQL-centric audience.

@@ -139,14 +143,14 @@ The input format is typically [detected automatically](#auto-detection) and the
"Auto" is "yes" in the table above support _auto-detection_.
Formats without auto-detection require the `-i` option.

### Hard-wired Input Format
#### Hard-wired Input Format
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #5481, a new "Data Formats" section was created and the "Input Formats" and "Output Formats" sub-sections were moved below that, which all makes sense. However, the sub-sections under "Input Formats" and "Output Formats" were left at their prior level, so the hierarchical order was disrupted. This and other ####-style changes in this PR are to correct that.

@philrz philrz marked this pull request as ready for review November 17, 2024 20:17
@philrz philrz requested a review from a team November 17, 2024 20:17
@philrz philrz merged commit 1aa08f3 into main Nov 18, 2024
4 checks passed
@philrz philrz deleted the super-cmd-doc-edits branch November 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants