describe endpoint: source inference #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattnibs
changed the title
mattnibs
force-pushed
the
describe-inferred
branch
from
06375a7
to
c0dcfcc
Compare
nwt
reviewed
Jun 12, 2024
| URI string `json:"uri"` | ||
| Kind string `json:"kind"` | ||
| URI string `json:"uri"` | ||
| Inferred bool `json:"inferred"` |
There was a problem hiding this comment.
Won't this always be false for a path? If so, is there any reason to keep it?
Suggested change
| Inferred bool `json:"inferred"` |
There was a problem hiding this comment.
I mean technically you'll never use this endpoint for non-pools but I left that in for completion and because you might want to use this package to inspect source of a different kind. But to your point path can be inferred. At least on the semantic side if no source exists we prepend &dag.DefaultScan{Kind: "DefaultScan"} to the sequence.
nwt
reviewed
Jun 12, 2024
Update the describe endpoint to include whether or not the source of a query was inferred.
mattnibs
force-pushed
the
describe-inferred
branch
from
c0dcfcc
to
b697b40
Compare
nwt
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the describe endpoint to include whether or not the source of a query was inferred.