Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for ignored_formats #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

refaelos
Copy link

This fork adds the ability to ignore curtain request formats from being mobilized. You might want to return JSON for :json or :iphone mime types and not let mobile_fu convert your format to :mobile.

Usage example at the end of README.rdoc file.

…es where you have a mobile phone that should get a json return type instead of a mobile website. also, fixed a bug in "set_mobile_format" - setting request.format instead of :html on line 88
@woahdae
Copy link

woahdae commented Jan 24, 2012

+1 in general, although a quick look at the patch shows that it's an api-breaking change. I do like the way you have it, but IMO you should handle the case of passing true as the option hash for backwards compatibility. That is if anyone notices the patch :)

@refaelos
Copy link
Author

I changed the code to support backward compatibility.

dlnichols referenced this pull request in dlnichols/mobile-fu Dec 13, 2012
Added Nexus 7 to the list of Tablet devices.
@benlangfeld
Copy link

This project is abandoned. Please see the active fork at http://github.com/benlangfeld/mobile-fu. Please test with the released gem and master branch of the new home for the project, and file an issue on the other repo if you still have problems.

See #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants