uprobe: Enhance the 'check command deps' code to check all dependenci… #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es in a single loop, and show all at one shot to the end-user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the script currently works, if, say, 2 utils (objdump and awk) are not installed/missing, the script would first exit saying that 'objdump' is missing. On install of objdump by the end-user and a rerun, it would then crib about 'awk' missing; why twice (or more)!?
This commit checks all dependency commands/utilities at one shot, and reports the ones that are missing at once, so that the end-user can install all and then retry.