Use locking mechanism as intended in unsafe_add_column #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +49,12 @@ def self.delegate_unsafe_method_to_migration_base_class(method_name) | |||
| disable_or_delegate_default_method :remove_index, ":remove_index is NOT SAFE! Use safe_remove_concurrent_index instead for Postgres 9.6 databases; Explicitly call :unsafe_remove_index to proceed on Postgres 9.1" | |||
| disable_or_delegate_default_method :add_foreign_key, ":add_foreign_key is NOT SAFE! Explicitly call :unsafe_add_foreign_key only if you have guidance from a migration reviewer in #service-app-db." | |||
|
|
|||
| def unsafe_add_column(table, column, type, options = {}) | |||
| safely_acquire_lock_for_table(table) do | |||
There was a problem hiding this comment.
It's a little unfortunate that we now have an implicit dependency in this file on this method in safe_statements; but the only alternative I can see is calling execute_ancestor_statement in that file, which is not an improvement. Perhaps they could be moved to a separate helper module.
|
This is a good catch; I'd like to discuss among our team internally as to the questions about file dependencies, but the approach looks generally correct. |
|
Closing the PR for now since it's been open for so long. If someone else wants to pick this up that'd be great. This is probably a good starting point for #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22 .