Improve build performance #112
Merged
+829
−825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrage
force-pushed
the
build-speedup
branch
from
738eedb
to
27eff54
Compare
|
Before: 
After: 
|
jcoleman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff is basically impossible to view, but the TLDR is that I moved the following utility methods out of the
PgHaMigrations::AllowedVersions::ALLOWED_VERSIONSloop:safely_acquire_lock_for_tableadjust_lock_timeoutadjust_statement_timeoutensure_small_tableThese methods do not exercise any of the backwards compatibility features of migrations, so we shouldn't need to run the tests for each migration version. The
safely_acquire_lock_for_tabletests are very slow, so this should hopefully speed things up significantly.